[codex] Support raw image offload in v1 train client#1746
Draft
eligotts wants to merge 2 commits into
Draft
Conversation
This was referenced Jun 18, 2026
7556743 to
3f5bb1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pixel_values,image_embeds, andimage_featuresprime_raw_mm_itemenvelopes instead of descriptor-only Qwen payloadsCompanion PRs
Notes
Validation
ruff check,ruff format, generated AGENTS/CLAUDE check passed.ty (ci parity)passed./home/ubuntu/verifiers,/home/ubuntu/renderers, and/home/ubuntu/prime-rl-v1-raw-mm-offloadcompleted inference, env rollouts, train batch creation, trainer step 0, and decoded strict trainer-bound raw image refs.Note
Add raw image offload and multimodal bridging to v1 train client
offload_images_inplaceinutils/multimodal.pyto rewriteimage_urlparts in wire bodies and typed messages tofile://run assets in-place, enforcing that all image URLs resolve to file references.TrainClientnow calls image offload inprepare_request_bodyandprepare_messages, and bridges multimodal turns by forwardingprevious_multi_modal_datato the renderer on each turn._generate_with_image_ref_retryto retrygenerateonce withmaterialize_all_image_refs=Truewhen vLLM returns amissing_mm_cache_itemerror and only descriptor-only image refs are present.MessageNodeserialization/deserialization now rejects processed image payloads (e.g.pixel_valuesndarrays) and enforces raw image descriptors only;PendingTurngains aprevious_multi_modal_datamethod that merges sidecars across the reusable prefix.TypeErroron serialize or deserialize, which is a breaking change for any stored nodes carrying processed image tensors.Macroscope summarized 6f9c55e. (Automatic summaries will resume when PR exits draft mode or review begins).